Skip to content

Commit

Permalink
make Spark on Mesos use old spark shuffle fetch protocol (#85)
Browse files Browse the repository at this point in the history
* make Spark on Mesos use old spark shuffle fetch protocol

* bump requirements to appease github CI; bump package patch version
  • Loading branch information
nanflasted authored Aug 25, 2022
1 parent 44cbfb2 commit 4b904a9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
importlib-resources==1.5.0
importlib-resources==5.4.0
pyinotify==0.9.6
pyyaml >= 3.0
1 change: 1 addition & 0 deletions service_configuration_lib/spark_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,7 @@ def _get_mesos_spark_env(
'spark.mesos.constraints': f'pool:{paasta_pool}',
'spark.mesos.executor.docker.forcePullImage': 'true',
'spark.mesos.principal': 'spark',
'spark.shuffle.useOldFetchProtocol': 'true',
**auth_configs,
**_get_mesos_docker_volumes_conf(
user_spark_opts, extra_volumes,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

setup(
name='service-configuration-lib',
version='2.11.0',
version='2.11.1',
provides=['service_configuration_lib'],
description='Start, stop, and inspect Yelp SOA services',
url='https://github.com/Yelp/service_configuration_lib',
Expand Down
1 change: 1 addition & 0 deletions tests/spark_config_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,7 @@ def verify(output):
'spark.mesos.executor.docker.forcePullImage': 'true',
'spark.mesos.constraints': f'pool:{self.pool}',
'spark.mesos.principal': 'spark',
'spark.shuffle.useOldFetchProtocol': 'true',
}
for key, value in expected_output.items():
assert output[key] == value
Expand Down

0 comments on commit 4b904a9

Please sign in to comment.