Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spark app id naming convention and limit length #125

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Update spark app id naming convention and limit length #125

merged 2 commits into from
Aug 17, 2023

Conversation

edingroot
Copy link
Contributor

Follow up PR of #124

  • Trim app id to match k8s pod label length limit
  • For non-jupyterhub jobs: use <paasta_service>_<paasta_instance>_<timestamp> format

88manpreet
88manpreet approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@88manpreet 88manpreet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to release the paasta version change for this early morning on LDN time, to catch any failing batches sooner.
ship-it once comments are addressed

@edingroot edingroot merged commit ebaf3bf into master Aug 17, 2023
1 check passed
@edingroot edingroot deleted the u/chi/spark_app_id_update branch August 17, 2023 20:08
@edingroot edingroot mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@88manpreet 88manpreet 88manpreet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edingroot @88manpreet @chi-yelp