Tie OPT weights #23
Merged
Tie OPT weights #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigranfah
approved these changes
Sep 18, 2024
torchtitan/models/opt/model.py
Outdated
| @@ -364,8 +362,7 @@ def forward(self, tokens: torch.Tensor): | |||
| h = layer(h) | |||
|
|
|||
| h = self.norm(h) if self.norm else h | |||
| output = self.output(h).float() if self.output else h | |||
| return output | |||
| return self.output(h) | |||
There was a problem hiding this comment.
why not cast the outputs to float?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ties the weights of input and output embeddings for the OPT model via a minimal implementation