dreamfactorysoftware#305 - Fix roles saving issue

Yi-Jacob · Aug 26, 2024 · 8aa6145 · 8aa6145
1 parent 00d9bcd
commit 8aa6145
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/app/adf-roles/df-role-details/df-role-details.component.ts b/src/app/adf-roles/df-role-details/df-role-details.component.ts
@@ -119,7 +119,8 @@ export class DfRoleDetailsComponent implements OnInit {
                   ),
                   component: new FormControl(item.component),
                   access: new FormControl(
-                    this.handleAccessValue(item.verbMask)
+                    this.handleAccessValue(item.verbMask),
+                    [Validators.required]
                   ),
                   requester: new FormControl(
                     this.handleRequesterValue(item.requestorMask)
@@ -257,7 +258,7 @@ export class DfRoleDetailsComponent implements OnInit {
   }
 
   onSubmit() {
-    // if (this.roleForm.invalid) return;
+    if (this.roleForm.invalid) return;
     const formValue = this.roleForm.getRawValue();
     if (formValue.name === '' || formValue.name === null) return;
     const payload: RolePayload = {

diff --git a/src/app/adf-roles/df-roles-access/df-roles-access.component.ts b/src/app/adf-roles/df-roles-access/df-roles-access.component.ts
@@ -184,7 +184,7 @@ export class DfRolesAccessComponent implements OnInit {
     this.initializeFilteredComponents();
 
     this.updateDataSource();
-    this.add();
+    // this.add();
   }
   get cFormArray(): FormArray {
     return this.form.get('formArray') as FormArray;