Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue #12679 #2

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Resolve issue #12679 #2

merged 2 commits into from
Oct 19, 2024

Conversation

Yokyeee1114
Copy link
Owner

@Yokyeee1114 Yokyeee1114 commented Oct 19, 2024

Fixes TEAMMATES#12679
Outline of Solution
My teammates and I analyzed and discussed the ts file for detecting the input of newfeedbacksessionname.
We found that the field was not checked for validity before the copy button was pressed.
We have now added a series of methods such as trim() to determine whether there are illegal spaces in the field.

Outline of Solution

Copy link

Hi @Yokyeee1114, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

Copy link
Collaborator

@u7721487 u7721487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved #1 Code is easy to read and work well in my environment

@Yokyeee1114
Copy link
Owner Author

I already fixed it but for somehow the test didn't pass.

@Yokyeee1114 Yokyeee1114 merged commit 3945632 into master Oct 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying feedback session: Name for copied session should not be whitespace
3 participants