Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rbac to set useful labels on broker pods from init script #117

Merged
merged 4 commits into from
Jan 8, 2018

Conversation

solsson
Copy link
Contributor

@solsson solsson commented Jan 8, 2018

I thought kubernetes/kubernetes#55329 would make such labels obsolete, but seeing that k8s 1.9 sets for example statefulset.kubernetes.io/pod-name: kafka-0 I think they complement each other.

Moreover #78 depends on the kafka-broker-id for the ./outsite-services/ per-broker service.

to speed up a bit and reduce the risk that it interferes with actual config.
Also if the init script goes crash looping you won't get warnings about
labels already being set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant