Upgrade to Kafka 2.0.0 and Zookeeper 3.4.13 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just to mention - Burrow may stop working, see linkedin/Burrow#440 |
This is the first Kafka release to officially support Java >8. We should stabilize on it ASAP because of improved docker support in JDK 10+. See https://blog.docker.com/2018/04/improved-docker-container-integration-with-java-10/
solsson
added a commit
that referenced
this pull request
Nov 28, 2018
which probably makes the discussion in #112 outdated. Instead we could discuss -XX:MaxRAMPercentage and related flags from http://bugs.java.com/view_bug.do?bug_id=JDK-8186248
as soon as they apply any non-testing load, but still high enough to support for example this repo's eventrouter + tests.
same argument as stated in the 50kafka.yml manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @mikenorgate for alerting me on why the zookeeper upgrade is important. We haven't applied this in production yet though.
Edit: Yolean never did the upgrade to 2.0.0 so I didn't merge. Now this PR is instead for Kafka 2.1.0 on Java 11 with images from solsson/dockerfiles#19. It's clearly a destabilization, motivated by the importance of native support for containers in Java.
While destabilizing we will also merge other potentially breaking changes, as tracked by the 5.0 milestone.