Mount config and use debian based image #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use config map for broker configuration
tenfold in confusion caused by typos etc
you must use /opt/kafka/config, due to how log4j.properites (sometimes tools- or connect-) are resolved by the ./bin scripts. See solsson/dockerfiles#10
to not mix with sample config. See solsson/dockerfiles#10.
of not forwarding signals as Alpine did. Kafka logs say nothing, and after 30s the container is terminated. With /bin/bash instead the log indicates shutdown behavior. This reverts commit c188f43.
modify config prior to kafka start. My aim with this is to get rid of the /bin/sh startup scripts and use bin + args directly.
avoiding a layer of indirection and the associated gotchas with signals.
Use init container for per-pod config
|
Learned that Debian's default shell has the same gotcha, when used as entrypoint, as Alpine's: a2d324d. Anyway with the init container concept we don't need a wrapping shell anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding ever more
--overridecommands, as seen in for example #13 (comment). #41 will require some amazing bash one-line stuff, or that we use a script to modify the properties file. To keep options open here I'm (re-)introducing a ConfigMap for Kafka server start.With this change we have to reflect on the assumptions we make about the Kafka image. Choice of shell and paths affect Kubernetes manifests. Choice of base image (contestant are Debian and Alpine) profoundly affects how the projects matures WRT for example resource limits. Maturity with Alpine would mean we risk lots if regressions if we switch. Thus I wanted to do some image work, as motivated solsson/dockerfiles#5.
I'm still hesitant about solsson/dockerfiles#10. The image will be a leaky abstraction anyway, and drop-in replacements are unlikely for the same reason as above of maturing.