Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify devloops that include a runtime build #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify devloops that include a runtime build #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5179727
Do we still have this issue?
solsson May 11, 2021
7a10918
Supports locally built & locally docker buildable runtime changes
solsson May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions bin/y-build-like-sync
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,25 @@ RUNTIME_IMAGE=$1
[ -z "$RUNTIME_IMAGE" ] && echo "First argument must be a runtime image to append the layer to" \
&& echo "To improve build times use a runtime image in the target repo" && exit 1

# crane hangs for a long time if it doesn't know that the registry is plain http
RUNTIME_IMAGE=$(echo $RUNTIME_IMAGE | sed 's|.local/|.local:80/|')
IMAGE=$(echo $IMAGE | sed 's|.local/|.local:80/|')
# Experimental support for runtime dev loops
case "$RUNTIME_IMAGE" in
$BUILDS_REGISTRY*-dirty )
docker inspect $RUNTIME_IMAGE >/dev/null && docker push $RUNTIME_IMAGE || true
;;
$BUILDS_REGISTRY*:../* )
RUNTIME_BUILD_CONTEXT=$(echo $RUNTIME_IMAGE | cut -d':' -f 2)
RUNTIME_IMAGE=$(echo $RUNTIME_IMAGE | cut -d':' -f 1):y-build-like-sync-devloop
docker build -t $RUNTIME_IMAGE $RUNTIME_BUILD_CONTEXT
docker push $RUNTIME_IMAGE
;;
$BUILDS_REGISTRY* )
y-crane validate --remote=$RUNTIME_IMAGE
;;
esac

# # crane hangs for a long time if it doesn't know that the registry is plain http
# RUNTIME_IMAGE=$(echo $RUNTIME_IMAGE | sed 's|.local/|.local:80/|')
# IMAGE=$(echo $IMAGE | sed 's|.local/|.local:80/|')

# This is a PoC, let's make a lot of assumptions to simplify
context=.
Expand Down