Adding NanoXplore NG-Ultra support #1397
Open
+12,814
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatecat
reviewed
Nov 27, 2024
|
|
||
| void add_net(std::set<std::string> &nets, std::string src_tile, std::string src_name, std::string dst_tile, std::string dst_name, IdString src_type, IdString dst_type) | ||
| { | ||
| if (src_type.in(ctx->id("LUT_PERMUTATION_WIRE"), ctx->id("MUX_WIRE"), ctx->id("INTERCONNECT_INPUT"))) return; |
There was a problem hiding this comment.
can you ran a clangformat over the new uarch?
There was a problem hiding this comment.
Will run that as last commit. will first cover rest of comments
| void constrain_location(CellInfo *cell); | ||
| void extract_lowskew_signals(CellInfo *cell, dict<IdString,dict<IdString,std::vector<PortRef>>> &lowskew_signals); | ||
| // Cell creating | ||
| std::unique_ptr<CellInfo> create_cell(IdString type, IdString name); |
There was a problem hiding this comment.
for consistency, it would be better to have only one of these, probably just create_cell_ptr and refactor the few places where you want to create cells while iterating over them to also build a list and then iterate over that
| } | ||
|
|
||
| BelId NgUltraPacker::getCSC(Loc l, int row) | ||
| { |
There was a problem hiding this comment.
this feels like it could be written in a cleaner way
| } | ||
| const auto &bel_data = chip_bel_info(ctx->chip_info, bel); | ||
| const auto &extra_data = *reinterpret_cast<const NGUltraBelExtraDataPOD *>(bel_data.extra_data.get()); | ||
| std::string type = str_or_default(cell->params, ctx->id("type"), ""); |
There was a problem hiding this comment.
let's make this faster than copying a string, this could well be in the critical path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes work done in longer period that adds support for NG-Ultra architecture of NanoXplore using Himbaechel API.
It was done as part of Project Beyond and files needed for building chip database are now available at https://github.com/YosysHQ-GmbH/prjbeyond-db/.
Bitstream is exported in JSON format that is supported by Impulse tool from NanoXplore and it is used to generate binary bitstreams or additionally modify design.