App key #21
Open
App key #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent users from having to pass the app_key into every request even when they've set it in the config. It also allows them to pass in an app_key if they've not gone through the config step, or they have multiple app_keys. Example: ```ruby Yotpo.configure do |config| config.app_key = ENV['yotpo_key'] config.secret = ENV['yotpo_secret'] end Yotpo.get_product_bottom_line(product_id: "fake-product") Yotpo.get_product_bottom_line(app_key: 'totallydifferentappkey', product_id: "fake-product") ```
|
If this is not desirable to anybody, I'll close it. Also happy to make any changes recommended. |
|
This seems like a good idea -- it's really strange that there are steps to configure the app key and secret, and then we must continue to pass it in for each call... |
fastjames
reviewed
Dec 13, 2018
| @@ -1,3 +1,3 @@ | |||
| module Yotpo | |||
| VERSION = '1.0.1' | |||
| VERSION = '1.0.2' | |||
There was a problem hiding this comment.
I would put the version change in a separate commit / PR.
There was a problem hiding this comment.
Why did Yotpo not use this PR? Coming to this gem now, and it seems crazy to provide a known key on each and every call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent users from having to pass the app_key into every
request even when they've set it in the config. It also allows them to
pass in an app_key if they've not gone through the config step, or they
have multiple app_keys and wish to be explicit with which one they use.
Example: