Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pattern escape #601

Closed
wants to merge 2 commits into from
Closed

Conversation

cm-ayf
Copy link

@cm-ayf cm-ayf commented May 11, 2024

This PR fixes control character handling when emitting regex patterns. The list of control characters are obtained from https://json-schema.org/understanding-json-schema/reference/regular_expressions.

Please:

  • Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.
  • Provide a test case & update the documentation in the Readme.md

@domoritz
Copy link
Collaborator

This might be covered by #603 by ahochsteger.

@cm-ayf
Copy link
Author

cm-ayf commented May 15, 2024

I have confirmed that the issue was resolved. Closing this PR...

@cm-ayf cm-ayf closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants