Skip to content

Commit

Permalink
Revert new experimental interfaces and classes
Browse files Browse the repository at this point in the history
These will be postponed to the next minor version instead.
  • Loading branch information
emlun committed Jan 16, 2025
1 parent 798ec03 commit 0cbba57
Show file tree
Hide file tree
Showing 22 changed files with 282 additions and 11,095 deletions.
31 changes: 0 additions & 31 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -29,37 +29,6 @@ New features:
instead of an ordinary WebAuthn response. See the JavaDoc for details.
** NOTE: Experimental features may receive breaking changes without a major
version increase.
* (Experimental) Added a new suite of interfaces, starting with
`CredentialRepositoryV2`. `RelyingParty` can now be configured with a
`CredentialRepositoryV2` instance instead of a `CredentialRepository`
instance. This changes the result of the `RelyingParty` builder to
`RelyingPartyV2`. `CredentialRepositoryV2` and `RelyingPartyV2` enable a suite
of new features:
** `CredentialRepositoryV2` does not assume that the application has usernames,
instead username support is modular. In addition to the
`CredentialRepositoryV2`, `RelyingPartyV2` can be optionally configured with
a `UsernameRepository` as well. If a `UsernameRepository` is not set, then
`RelyingPartyV2.startAssertion(StartAssertionOptions)` will fail at runtime
if `StartAssertionOptions.username` is set.
** `CredentialRepositoryV2` uses a new interface `CredentialRecord` to
represent registered credentials, instead of the concrete
`RegisteredCredential` class (although `RegisteredCredential` also
implements `CredentialRecord`). This provides implementations greater
flexibility while also automating the type conversion to
`PublicKeyCredentialDescriptor` needed in `startRegistration()` and
`startAssertion()`.
** `RelyingPartyV2.finishAssertion()` returns a new type `AssertionResultV2`
with a new method `getCredential()`, which returns the `CredentialRecord`
that was verified. The return type of `getCredential()` is generic and
preserves the concrete type of `CredentialRecord` returned by the
`CredentialRepositoryV2` implementation.
** NOTE: Experimental features may receive breaking changes without a major
version increase.
* (Experimental) Added property `RegisteredCredential.transports`.
** NOTE: Experimental features may receive breaking changes without a major
version increase.
** NOTE: Experimental features may receive breaking changes without a major
version increase.

`webauthn-server-attestation`:

Expand Down

This file was deleted.

Loading

1 comment on commit 0cbba57

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutation test results

Package Coverage Stats Prev Prev
Overall 77 % 🔻 1405 🔻 / 1804 🔻 78 % 1475 / 1878
com.yubico.fido.metadata 69 % 🟢 233 🔺 / 337 🔹 68 % 231 / 337
com.yubico.internal.util 44 % 🔻 127 🔻 / 288 🔹 44 % 129 / 288
com.yubico.webauthn 88 % 🔻 586 🔻 / 663 🔻 89 % 656 / 736
com.yubico.webauthn.attestation 93 % 🔹 15 🔹 / 16 🔹 93 % 15 / 16
com.yubico.webauthn.data 92 % 🔹 419 🔹 / 453 🔻 92 % 419 / 454
com.yubico.webauthn.extension.appid 100 % 🏆 13 🔹 / 13 🔹 100 % 13 / 13
com.yubico.webauthn.extension.uvm 50 % 🔹 12 🔹 / 24 🔹 50 % 12 / 24
com.yubico.webauthn.meta 0 % 🔹 0 🔹 / 10 🔹 0 % 0 / 10

Previous run: 798ec03 - Diff

Detailed reports: workflow run #292

Please sign in to comment.