Remove self-contradicting test assertion #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is named `goodResult`, implying that the verification should be a success, but the assertion checks that the verification should be a failure. The arguments to `verifyX5cRequirements` are the same as above for the `result` variable with `badCert`. This code is probably a copy-paste error.
Test Results2 220 tests 2 212 ✅ 57s ⏱️ Results for commit 1f0a741. |
fdennis
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is named
goodResult, implying that the verification should be a success, but the assertion checks that the verification should be a failure. The arguments toverifyX5cRequirementsare the same as above for theresultvariable withbadCert. This code is probably a copy-paste error.