hid_netbsd: move null pointer check before dereference

Found when trying out smatch
Yubico · Feb 5, 2024 · c4c7685 · c4c7685
1 parent 3b8e322
commit c4c7685
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/hid_netbsd.c b/src/hid_netbsd.c
@@ -127,14 +127,14 @@ fido_hid_manifest(fido_dev_info_t *devlist, size_t ilen, size_t *olen)
 	char	path[64];
 	size_t	i;
 
+	if (devlist == NULL || olen == NULL)
+		return (FIDO_ERR_INVALID_ARGUMENT);
+
 	*olen = 0;
 
 	if (ilen == 0)
 		return (FIDO_OK); /* nothing to do */
 
-	if (devlist == NULL || olen == NULL)
-		return (FIDO_ERR_INVALID_ARGUMENT);
-
 	for (i = *olen = 0; i < MAX_UHID && *olen < ilen; i++) {
 		snprintf(path, sizeof(path), "/dev/uhid%zu", i);
 		if (copy_info(&devlist[*olen], path) == 0) {