-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for SCP #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java
Dismissed
Show dismissed
Hide dismissed
management/src/main/java/com/yubico/yubikit/management/ManagementSession.java
Fixed
Show fixed
Hide fixed
core/src/main/java/com/yubico/yubikit/core/smartcard/AppId.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/Scp03KeyParams.java
Fixed
Show fixed
Hide fixed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/Scp11KeyParams.java
Fixed
Show fixed
Hide fixed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/Scp11KeyParams.java
Fixed
Show fixed
Hide fixed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/SecurityDomainSession.java
Fixed
Show fixed
Hide fixed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/SecurityDomainSession.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/StaticKeys.java
Dismissed
Show dismissed
Hide dismissed
Deprecate individual configuration methods on SmartCardProtocol in favor of a single .configure() method. Make ApduProcessor Closable. Add SCP support to YubiOtpSession.
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java
Dismissed
Show dismissed
Hide dismissed
It's not supported by the JVM in general, so no use implementing it now.
testing/src/main/java/com/yubico/yubikit/testing/openpgp/OpenPgpDeviceTests.java
Dismissed
Show dismissed
Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/openpgp/OpenPgpDeviceTests.java
Dismissed
Show dismissed
Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/openpgp/OpenPgpDeviceTests.java
Fixed
Show fixed
Hide fixed
testing/src/main/java/com/yubico/yubikit/testing/openpgp/OpenPgpDeviceTests.java
Fixed
Show fixed
Hide fixed
testing/src/main/java/com/yubico/yubikit/testing/oath/OathDeviceTests.java
Dismissed
Show dismissed
Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/oath/OathTestUtils.java
Fixed
Show fixed
Hide fixed
testing/src/main/java/com/yubico/yubikit/testing/fido/BasicWebAuthnClientTests.java
Dismissed
Show dismissed
Hide dismissed
testing/src/main/java/com/yubico/yubikit/testing/sd/Scp11TestData.java
Dismissed
Show dismissed
Hide dismissed
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/ScpState.java
Dismissed
Show dismissed
Hide dismissed
dainnilsson
commented
Aug 9, 2024
testing/src/main/java/com/yubico/yubikit/testing/piv/PivTestState.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/yubico/yubikit/core/smartcard/scp/Scp11KeyParams.java
Outdated
Show resolved
Hide resolved
AdamVe
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for Security Domain session.