Skip to content

Commit

Permalink
Remove redundant s3 tests (facebookincubator#9959)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: facebookincubator#9959

Reviewed By: kagamiori, kewang1024

Differential Revision: D57868773

Pulled By: xiaoxmeng

fbshipit-source-id: baddf6401b53b229955d41769137206a3b8a440d
  • Loading branch information
xiaoxmeng authored and facebook-github-bot committed May 28, 2024
1 parent 188f5b9 commit 5ef1409
Showing 1 changed file with 0 additions and 34 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,40 +60,6 @@ TEST_F(S3FileSystemTest, writeAndRead) {
readData(readFile.get());
}

TEST_F(S3FileSystemTest, viaRegistry) {
const char* bucketName = "data2";
const char* file = "test.txt";
const std::string filename = localPath(bucketName) + "/" + file;
const std::string s3File = s3URI(bucketName, file);
addBucket(bucketName);
{
LocalWriteFile writeFile(filename);
writeData(&writeFile);
}
auto hiveConfig = minioServer_->hiveConfig();
auto s3fs = filesystems::getFileSystem(s3File, hiveConfig);
auto readFile = s3fs->openFileForRead(s3File);
readData(readFile.get());
}

TEST_F(S3FileSystemTest, fileHandle) {
const char* bucketName = "data3";
const char* file = "test.txt";
const std::string filename = localPath(bucketName) + "/" + file;
const std::string s3File = s3URI(bucketName, file);
addBucket(bucketName);
{
LocalWriteFile writeFile(filename);
writeData(&writeFile);
}
auto hiveConfig = minioServer_->hiveConfig();
FileHandleFactory factory(
std::make_unique<SimpleLRUCache<std::string, FileHandle>>(1000),
std::make_unique<FileHandleGenerator>(hiveConfig));
auto fileHandle = factory.generate(s3File);
readData(fileHandle->file.get());
}

TEST_F(S3FileSystemTest, invalidCredentialsConfig) {
{
const std::unordered_map<std::string, std::string> config(
Expand Down

0 comments on commit 5ef1409

Please sign in to comment.