Skip to content

Commit

Permalink
Fix macOS build failure
Browse files Browse the repository at this point in the history
Summary:
For some reason compilation on macOS is inferring a tuple with long
instead of the long long expected and failing. Explicitly instantiating the
right tuple type to fix it.

Reviewed By: kgpai, bikramSingh91

Differential Revision: D56551487

fbshipit-source-id: 051c8b95f256d2645116cc2e757f16e86fe7b2b2
  • Loading branch information
pedroerp authored and facebook-github-bot committed Apr 25, 2024
1 parent a40dd55 commit a689fd4
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions velox/type/tests/TimestampConversionTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,8 @@ TEST(DateTimeUtilTest, fromTimestampStringInvalid) {

TEST(DateTimeUtilTest, fromTimestampWithTimezoneString) {
// -1 means no timezone information.
EXPECT_EQ(
fromTimestampWithTimezoneString("1970-01-01 00:00:00"),
std::make_pair(Timestamp(0, 0), -1L));
auto expected = std::make_pair<Timestamp, int64_t>(Timestamp(0, 0), -1);
EXPECT_EQ(fromTimestampWithTimezoneString("1970-01-01 00:00:00"), expected);

// Test timezone offsets.
EXPECT_EQ(
Expand Down

0 comments on commit a689fd4

Please sign in to comment.