Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPK: Add new approach #51

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

FPK: Add new approach #51

wants to merge 17 commits into from

Conversation

daoneandonly
Copy link
Contributor

@daoneandonly daoneandonly commented Sep 30, 2021

Add new approach to vue-flagpack

With the new version of flagpack-core combined with a new approach, vue-flagpack needed to make use of this approach.

Changes 🛠️

  • Add generateFlags.js script to generate flags based on flagpack-core
  • Add flags through the use of generateFlags.js
  • Add rollup image loader to properly load in SVGs
  • Add dynamic require of Flag SVGs.

Todo 🚧

  • Add Vue3 support. This will be done in a seperate PR.
  • Update Docs

dependabot bot and others added 9 commits May 28, 2021 19:24
Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/commits)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@rvmourik
Copy link

rvmourik commented Oct 6, 2021

Hi! Is this the works for #49? Would be appreciated :-) Love the library, but the bundle size is enormous when generating a static website which only needs a flag or 10 :-)

Keep up the good work, thanks.

@rvmourik
Copy link

Hi @daoneandonly

Is there any update on the ETA of this update?

Thanks in advance.

Robbert

@rvmourik
Copy link

@daoneandonly any change this is going to be finalized? flagpack core 2.0 would be very nice to use in Vue(3) projects.

@daoneandonly
Copy link
Contributor Author

@rvmourik We ran into a major bump trying to get a dynamic require working for our flagpack framework packages, in order to provide some treeshaking of unused flags. Current improvements on flagpack-vue are therefore postponed while figure out either a new solution or approach.

However, I can look into just adding the flags from flagpack 2.0 to flagpack-vue, if that offers any help.

Responding to #34 : Currently, given its current state, I have no ETA on when or even if flagpack-vue will support Vue3.

@rvmourik
Copy link

rvmourik commented Aug 2, 2022

@rvmourik We ran into a major bump trying to get a dynamic require working for our flagpack framework packages, in order to provide some treeshaking of unused flags. Current improvements on flagpack-vue are therefore postponed while figure out either a new solution or approach.

However, I can look into just adding the flags from flagpack 2.0 to flagpack-vue, if that offers any help.

Responding to #34 : Currently, given its current state, I have no ETA on when or even if flagpack-vue will support Vue3.

Thanks, no I am only interested a Vue 3 compatible package.

Hope you'll find a solution for it. Good Luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants