fix: 拼团记录，虚拟成团数有误 #720
Open
fix: 拼团记录，虚拟成团数有误 #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunaiV
reviewed
Dec 12, 2024
| @@ -240,4 +240,10 @@ public CombinationActivityDO getMatchCombinationActivityBySpuId(Long spuId) { | |||
| return combinationActivityMapper.selectBySpuIdAndStatusAndNow(spuId, CommonStatusEnum.ENABLE.getStatus()); | |||
| } | |||
|
|
|||
| @Override | |||
| public List<CombinationActivityDO> getByVirtualGroup() { | |||
There was a problem hiding this comment.
具体查询，建议放到 mapper 里。
service 不要有 dao 操作
YunaiV
reviewed
Dec 12, 2024
| } | ||
|
|
||
| // virtualGroup 为 true 的时候，查询虚拟成团的数量 | ||
| List<CombinationActivityDO> activities = combinationActivityService.getByVirtualGroup(); |
| } | ||
|
|
||
| List<Long> activityIds = convertList(activities, CombinationActivityDO::getId); | ||
| return combinationRecordMapper.selectCountByHeadAndStatusAndActivityIds(activityIds, status, headId); |
There was a problem hiding this comment.
需要activityIds过滤。从数据上看，虚拟成团（virtual_group）在 promotion_combination_record ，真实用户记 true。虚拟用户记 false。导致只能依靠activityIds筛选出虚拟成团的数据。
There was a problem hiding this comment.
是不是不拿 activityIds 过滤，直接通过 “真实用户记 true。虚拟用户记 false”，也可以呀？
There was a problem hiding this comment.
有个疑问：在拼团活动支持虚拟成团的情况下，一个队伍（全是真实用户），一个队伍（存在虚拟用户），那么在统计页面【拼团记录——虚拟成团（个）】预期是2 还是1？
|
我想了一下，是不是应该在 @GetMapping("/get-summary")
@Operation(summary = "获得拼团记录的概要信息", description = "用于拼团记录页面展示")
@PreAuthorize("@ss.hasPermission('promotion:combination-record:query')")
public CommonResult<CombinationRecordSummaryVO> getCombinationRecordSummary() {
CombinationRecordSummaryVO summaryVO = new CombinationRecordSummaryVO();
summaryVO.setUserCount(combinationRecordService.getCombinationUserCount()); // 获取拼团用户参与数量
summaryVO.setSuccessCount(combinationRecordService.getCombinationRecordCount( // 获取成团记录
CombinationRecordStatusEnum.SUCCESS.getStatus(), null, CombinationRecordDO.HEAD_ID_GROUP));
summaryVO.setVirtualGroupCount(combinationRecordService.getCombinationRecordCount(// 获取虚拟成团记录
null, Boolean.TRUE, CombinationRecordDO.HEAD_ID_GROUP));
return success(summaryVO);
}把 summaryVO.setVirtualGroupCount(combinationRecordService.getCombinationRecordCount(// 获取虚拟成团记录
null, Boolean.TRUE, CombinationRecordDO.HEAD_ID_GROUP));改成 summaryVO.setVirtualGroupCount(combinationRecordService.getCombinationRecordCount(// 获取虚拟成团记录
null, Boolean.TRUE, null));更合理噢？就是不限制 headId |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
知识星球提的关于“拼团记录，虚拟成团（个）查询有误”的PR
