Change default value of show_other_domains_apps to True #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having other domains' apps is a special use case, and newbies will just want to see all apps. It's more intuitive to set it to True
|
So it currently means that if we have domainA.tld and domainB.tld, when i click from domainA.tld/yunohost/sso/ on tile going on domainB.tld, i arrive on the second portal domainB.tld/yunohost/sso/ , i have to relogin (due to cookie same_site=strict cookie policy and domain limited) and after i can access a protected APP... |
Yes, indeed, that might be something nice to fix. But… At least people can see the tile for the other domain's app and click on it. So even if they won't understand why they need to re-login, they can see the app is installed and won't ask "hey $packager, your app doesn't appear on the dashboard". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having other domains' apps is a special use case, and newbies will just want to see all apps.
It's more intuitive to set it to True