Fix firewall #2038
Fix firewall #2038
Conversation
| for protocol, ports in firewall.config.items(): | ||
| for port, info in ports.items(): | ||
| for protocol in ["tcp", "udp"]: | ||
| for port, info in firewall.config[protocol].items(): |
There was a problem hiding this comment.
Hmmm that kind of stuff makes me paranoid about wether or not the expected keys does exist in the file ... We've seen in the past situation where yaml file (app settings) became empty because at some point yunohost tries to update the file, but there's no space left on the server (eg because a backup went crazy and filled the disk) and then somehow the file still exists but is empty ...
I suppose one day or another, we'll also have users randomly editing the file with typos so I would also make sure that somehow the expected keys (tcp, udp, ..?) do exist in the file
Can we iterate on the def read(...) method for YunoFirewall adding failsafes such as returning a dict with the appropriate structure ? 😬
There was a problem hiding this comment.
Can we iterate on the def read(...) method for YunoFirewall adding failsafes such as returning a dict with the appropriate structure ? 😬
You mean just to ensure the dict in memory is valid ? Or to return an error if the file read doesn't comply to the expected structure ?
There was a problem hiding this comment.
Hmyeah I'd say return an error (or a warning and then some failsafe values) if for some reason we're unable to read the file or it doesn't have the expected structure
The problem
https://forum.yunohost.org/t/python-became-crazy/35186