Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added setter for table name AbstractDbMapper #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added setter for table name AbstractDbMapper #74

wants to merge 1 commit into from

Conversation

lrinaldi
Copy link

Add setter to $tableName

Update AbstractDbMapper.php
ed3d9e5 
Add setter to $tableName
@lrinaldi lrinaldi changed the title Update AbstractDbMapper.php Added setter for table name AbstractDbMapper Oct 17, 2014
@localheinz
Copy link
Contributor

@lrinaldi

Not so sure whether the table name of a concrete implementation of AbstractDbMapper should change over the lifetime of an instance of it, what do you think?

@adamlundrigan
Copy link
Contributor

@localheinz IMO it should be a constructor argument, but ZfcUser currently uses it's own implementation of setTableName to allow changing the table name so I guess we're stuck with it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lrinaldi @localheinz @adamlundrigan