This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
Start deleting #308
Merged
Start deleting #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn, making the tests pass will be a huge mess considering that we wrote them by trying to initialize a ZF2 module (...). Therefore I think I'll need to merge as it and fix that in a future PR. Is there anything you think could be removed? |
|
module.config.php could be removed as well? |
|
You're right! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone (special ping to @danizord and @arekkas )
This is the first step of my cleaning work as explained in #307
As said there, the goal is to make zfc-rbac no longer a ZF2 module, but a simpler library based on middleware paradigm (ZfcRbac 2.x will still be supported as a ZF2 library).
As a consequence, a lot of features do not make sense anymore. Guards for now will be removed but we may rethought them around middleware paradigm.
The first step of this PR is to simply remove features and make the tests pass.