Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update package.json #95

Merged
merged 1 commit into from
Sep 15, 2024
Merged

chore: update package.json #95

merged 1 commit into from
Sep 15, 2024

Conversation

RalXYZ
Copy link
Member

@RalXYZ RalXYZ commented Sep 10, 2024 •
edited
Loading

Update dependencies, see in package.json

Breaking changes:

  • done:
    • http-proxy-middleware v2 -> v3
    • prism-react-renderer v1 -> v2
    • @mui/material v5 -> v6

@RalXYZ RalXYZ added the dependencies Pull requests that update a dependency file label Sep 10, 2024
@RalXYZ RalXYZ self-assigned this Sep 10, 2024
@RalXYZ RalXYZ marked this pull request as ready for review September 12, 2024 13:55
@RalXYZ
Copy link
Member Author

RalXYZ commented Sep 12, 2024

Please run on your own device before approving this pr

determ1ne
determ1ne requested changes Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@determ1ne determ1ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovell/sharp 作为依赖版本被更新了，目前 node:20 (debian 12) 中的 libvips 版本低于 sharp 的要求，所以 npm ci 时需要从 github 中下载文件，可能会导致网络问题。

  1. 在 gitlab ci 中添加新版 libvips 的构建/安装
  2. 手动锁定 sharp 到低版本

ref:

@RalXYZ RalXYZ merged commit 07311c9 into main Sep 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@determ1ne determ1ne determ1ne approved these changes

Assignees

@RalXYZ RalXYZ

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalXYZ @determ1ne