Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compatibility table): 🚑 Add missing STM32F405RG string to deviceNames[] array #107

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

ZZ-Cat
Copy link
Owner

@ZZ-Cat ZZ-Cat commented Apr 10, 2024

Overview

This is a hotfix for a missing entry in the Compatibilty Table that was preventing every target from STM32F407VE to Teensy 4.1 to internally fail the initialisation process.

What's changed

For details, see this comment

@ZZ-Cat ZZ-Cat linked an issue Apr 10, 2024 that may be closed by this pull request
1 task
@ZZ-Cat ZZ-Cat added the Bug Fix 👋💥🐞 Bug meet swatter! label Apr 10, 2024
@ZZ-Cat ZZ-Cat self-assigned this Apr 10, 2024
@ZZ-Cat ZZ-Cat added this to the Version 1.1.0 milestone Apr 10, 2024
@ZZ-Cat
Copy link
Owner Author

ZZ-Cat commented Apr 10, 2024

@christophers090, would you like to give this a whirl, and let me know how you get on?

@ZZ-Cat ZZ-Cat mentioned this pull request Apr 12, 2024
29 tasks
@ZZ-Cat ZZ-Cat added ⤴️ Rebase Needed ⤴️ This needs to be rebased. Stale 🚮 This is slated for automatic cleanup labels Apr 19, 2024
@ZZ-Cat ZZ-Cat removed the ⤴️ Rebase Needed ⤴️ This needs to be rebased. label Apr 24, 2024
@ZZ-Cat
Copy link
Owner Author

ZZ-Cat commented Apr 24, 2024

Right, I have update the branch associated with this Pull Request.

It looks like I may need to move the deviceNames[] array out of the *.hpp file and get it into the *.cpp file where it can be checked by my Quality Control.
With that being said, I may need to do the same with ct_devboards_e as well. Because in their current place, thar evading my Quality Control.

@ZZ-Cat
Copy link
Owner Author

ZZ-Cat commented Apr 24, 2024

I changed my mind on this.
I did some internal tests with the bug that this Pull Request fixes, and that bug still made it past my Quality Control... even when I brought the deviceNames and ct_devboards_e and associated structures into the source file. I found that the juice wasn't worth the squeeze... IE It brought no benefit, let alone what I was expecting.

Therefore, I am merging this as-is, and it is the last ghosted Pull Request.
All future ghosted Pull Requests are rejected, and their associated Issues marked as "unplanned" and closed.

@ZZ-Cat ZZ-Cat merged commit 0ed20d4 into Main-Trunk Apr 24, 2024
5 checks passed
@ZZ-Cat ZZ-Cat deleted the ZZ-Cat/issue104 branch April 24, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix 👋💥🐞 Bug meet swatter! Stale 🚮 This is slated for automatic cleanup
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Teensy 4.1 not working
1 participant