Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect database in dashboard (and add tests) #46

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

tybug
Copy link
Collaborator

@tybug tybug commented Dec 30, 2024

Contains a very rough start on a dashboard api - just enough to write a few basic tests.

@tybug tybug force-pushed the dashboard-tests branch 3 times, most recently from 2c0426d to 883530f Compare December 30, 2024 19:42
Copy link
Owner

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Liam!

@@ -2,6 +2,13 @@
HypoFuzz uses [calendar-based versioning](https://calver.org/), with a
`YY-MM-patch` format.

## 24.12.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll assume this is a poke to redate before merging! (and eventually set up some CI to do this for us)

Comment on lines +312 to +314
# todo: poll on a fixed interval (even if the page isn't loaded) instead of
# on every api request.
poll_database()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relatively easy way to do this: have poll_database() record when it last polled, and be a noop if that's within a few seconds - a kinda request-coalescing-flavored TTL setup.

(longer term, we'll want to extend our database interface to support incremental queries, but that's a whole nother design question)

@Zac-HD
Copy link
Owner

Zac-HD commented Jan 6, 2025

Also wow, synchronous web frameworks really draw my attention to latency-related perf issues these days. Eventually I'll want to switch us over to something like fastapi/starlette on trio/anyio, but that's for when or maybe after we get a custom non-plotly frontend set up. (Claude will help, I expect)

@tybug
Copy link
Collaborator Author

tybug commented Jan 6, 2025

sounds good, though I can live with the current dashboard for a bit longer while we nail down more foundational issues (#36)

@tybug tybug merged commit 2bd14c8 into Zac-HD:master Jan 6, 2025
13 checks passed
@tybug tybug deleted the dashboard-tests branch January 6, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants