-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect database in dashboard (and add tests) #46
Conversation
2c0426d
to
883530f
Compare
883530f
to
c9c9c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Liam!
docs-src/changelog.md
Outdated
@@ -2,6 +2,13 @@ | |||
HypoFuzz uses [calendar-based versioning](https://calver.org/), with a | |||
`YY-MM-patch` format. | |||
|
|||
## 24.12.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll assume this is a poke to redate before merging! (and eventually set up some CI to do this for us)
# todo: poll on a fixed interval (even if the page isn't loaded) instead of | ||
# on every api request. | ||
poll_database() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relatively easy way to do this: have poll_database()
record when it last polled, and be a noop if that's within a few seconds - a kinda request-coalescing-flavored TTL setup.
(longer term, we'll want to extend our database interface to support incremental queries, but that's a whole nother design question)
Also wow, synchronous web frameworks really draw my attention to latency-related perf issues these days. Eventually I'll want to switch us over to something like fastapi/starlette on trio/anyio, but that's for when or maybe after we get a custom non-plotly frontend set up. (Claude will help, I expect) |
sounds good, though I can live with the current dashboard for a bit longer while we nail down more foundational issues (#36) |
Contains a very rough start on a dashboard api - just enough to write a few basic tests.