Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing translation in chinese (simplified) #799

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

GaetanGrd
Copy link
Collaborator

Scope

closes TICKET-798

Implementation

Fix missing translation for the name of portguese (brazil) with chinese (simplified) language.

Screenshots

before after
image image

How to Test

  • go to settings
  • Select Chinese (simplified)
  • check brazil

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟢 Nice refactor!

🟡 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

🔴 This change will break something important

Blocking 🔴 ❌ 🚨 RED
Non-blocking 🟡 💡 🤔 💭 Yellow, thinking, etc
Praise 🟢 💚 😍 👍 🙌 Green, hearts, positive emojis, etc

@GaetanGrd GaetanGrd linked an issue Feb 8, 2025 that may be closed by this pull request
@GaetanGrd GaetanGrd requested a review from Zagrios February 8, 2025 18:44
@GaetanGrd GaetanGrd self-assigned this Feb 8, 2025
Copy link

sonarqubecloud bot commented Feb 8, 2025

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙌

@Zagrios
Copy link
Owner

Zagrios commented Feb 9, 2025

Thanks @GaetanGrd ❤️
Merging 🎉

@Zagrios Zagrios merged commit 51b4329 into master Feb 9, 2025
5 checks passed
@Zagrios Zagrios deleted the bugfix/translation-error/798 branch February 9, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] : translation error
2 participants