Skip to content

Commit

Permalink
fix: use correct pipeline conditions
Browse files Browse the repository at this point in the history
  • Loading branch information
gustavovalverde committed Oct 16, 2024
1 parent 2748e38 commit 8f51de0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/cd-deploy-nodes-gcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,7 @@ jobs:
permissions:
contents: 'read'
id-token: 'write'
# TODO: Remove `|| github.event_name == 'workflow_dispatch'` condition before merging
if: ${{ !cancelled() && !failure() && ((github.event_name == 'push' && github.ref_name == 'main') || github.event_name == 'release') || github.event_name == 'workflow_dispatch' }}
if: ${{ !cancelled() && !failure() && ((github.event_name == 'push' && github.ref_name == 'main') || github.event_name == 'release') }}

steps:
- uses: actions/[email protected]
Expand Down Expand Up @@ -295,7 +294,7 @@ jobs:
echo "zebra_checkpoint_disk=${ZEBRA_CHECKPOINT_DISK}" >> "${GITHUB_OUTPUT}"
- name: Get IP address for long-running release nodes
# if: ${{ github.event_name == 'release' }}
if: ${{ github.event_name == 'release' }}
run: echo "IP_ADDRESS=$(gcloud compute addresses describe zebra-${NETWORK} --region ${{ vars.GCP_REGION }} --format='value(address)')" >> "$GITHUB_ENV"

Check warning on line 298 in .github/workflows/cd-deploy-nodes-gcp.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/cd-deploy-nodes-gcp.yml#L298

shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting [shellcheck]
Raw output
.github/workflows/cd-deploy-nodes-gcp.yml:298:9: shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting [shellcheck]

- name: Create instance template for ${{ matrix.network }}
Expand Down

0 comments on commit 8f51de0

Please sign in to comment.