Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump incrementalmerkletree from 0.3.1 to 0.4.0 #6836

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 6, 2023

Bumps incrementalmerkletree from 0.3.1 to 0.4.0.

Commits
  • 4c79a7d Release incrementalmerkletree-v0.4.0 and bridgetree-v0.3.0
  • 66cf091 Merge branch 'release-bridgetree-v0.2.1' into HEAD
  • b2077aa Merge pull request #76 from nuttycom/narrow_hashable_constraint
  • a1dec49 Release of bridgetree v0.2.1
  • 87007ec Remove the Debug bound from Hashable
  • 69c9690 Merge pull request #74 from nuttycom/docfix
  • 2f65d48 Update shardtree/src/lib.rs
  • 51c3997 Fix incorrect documentation and cargo doc issues.
  • 62f0c90 Merge pull request #73 from nuttycom/frontier_witness
  • beb6ead Merge pull request #72 from nuttycom/no_initial_checkpoint
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [incrementalmerkletree](https://github.com/zcash/incrementalmerkletree) from 0.3.1 to 0.4.0.
- [Commits](zcash/incrementalmerkletree@incrementalmerkletree-v0.3.1...incrementalmerkletree-v0.4.0)

---
updated-dependencies:
- dependency-name: incrementalmerkletree
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner June 6, 2023 15:57
@dependabot dependabot bot requested review from teor2345 and removed request for a team June 6, 2023 15:57
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Jun 6, 2023
@dconnolly
Copy link
Contributor

There are incompatible API changes between 0.3* and 0.4*, asking Kris if this is intentional

@dconnolly
Copy link
Contributor

Frontier is now moved to incrementalmerkletree::frontier::Frontier
image

@teor2345
Copy link
Collaborator

teor2345 commented Jun 6, 2023

There are incompatible API changes between 0.3* and 0.4*, asking Kris if this is intentional

I think we should turn this into a ticket and do it as part of the RPC changes in #6642.

What do you think?

@teor2345 teor2345 removed their request for review June 6, 2023 20:20
@teor2345 teor2345 added the do-not-merge Tells Mergify not to merge this PR label Jun 6, 2023
@dconnolly
Copy link
Contributor

There are incompatible API changes between 0.3* and 0.4*, asking Kris if this is intentional

I think we should turn this into a ticket and do it as part of the RPC changes in #6642.

What do you think?

I agree, the 0.4.0 release was a significant refactor and we have to change more than a few things to update:

https://github.com/zcash/incrementalmerkletree/blob/master/incrementalmerkletree/CHANGELOG.md#040---2023-06-05

image image

@teor2345
Copy link
Collaborator

teor2345 commented Jun 6, 2023

I added this to #6642 instead.

@teor2345 teor2345 closed this Jun 6, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 6, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/incrementalmerkletree-0.4.0 branch June 6, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG do-not-merge Tells Mergify not to merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants