Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Add missing timeouts to CI and CD tests #7730

Merged
merged 2 commits into from
Oct 19, 2023
Merged

fix(ci): Add missing timeouts to CI and CD tests #7730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a5e4c7
Add missing timeouts to CI and CD tests
teor2345 Oct 18, 2023
3e99e30
Remove timeout keys that are not allowed by the syntax
teor2345 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/cd-deploy-nodes-gcp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
# Test that Zebra works using the default config with the latest Zebra version.
test-configuration-file:
name: Test CD default Docker config file
timeout-minutes: 60

Check warning on line 121 in .github/workflows/cd-deploy-nodes-gcp.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/cd-deploy-nodes-gcp.yml#L121 

when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-configuration-file" [syntax-check]
Raw output 
.github/workflows/cd-deploy-nodes-gcp.yml:121:5: when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-configuration-file" [syntax-check]
teor2345 marked this conversation as resolved.
Show resolved Hide resolved
needs: build
uses: ./.github/workflows/sub-test-zebra-config.yml
with:
Expand All @@ -130,6 +131,7 @@
# Test reconfiguring the docker image for testnet.
test-configuration-file-testnet:
name: Test CD testnet Docker config file
timeout-minutes: 60

Check warning on line 134 in .github/workflows/cd-deploy-nodes-gcp.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/cd-deploy-nodes-gcp.yml#L134 

when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-configuration-file-testnet" [syntax-check]
Raw output 
.github/workflows/cd-deploy-nodes-gcp.yml:134:5: when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-configuration-file-testnet" [syntax-check]
teor2345 marked this conversation as resolved.
Show resolved Hide resolved
needs: build
# Make sure Zebra can sync the genesis block on testnet
uses: ./.github/workflows/sub-test-zebra-config.yml
Expand All @@ -143,6 +145,7 @@
# Test that Zebra works using $ZEBRA_CONF_PATH config
test-zebra-conf-path:
name: Test CD custom Docker config file
timeout-minutes: 60

Check warning on line 148 in .github/workflows/cd-deploy-nodes-gcp.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/cd-deploy-nodes-gcp.yml#L148 

when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-zebra-conf-path" [syntax-check]
Raw output 
.github/workflows/cd-deploy-nodes-gcp.yml:148:5: when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-zebra-conf-path" [syntax-check]
teor2345 marked this conversation as resolved.
Show resolved Hide resolved
needs: build
uses: ./.github/workflows/sub-test-zebra-config.yml
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-build-crates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ jobs:

build:
name: Build ${{ matrix.crate }} crate
timeout-minutes: 90
needs: [ matrix, check-matrix ]
runs-on: ubuntu-latest
strategy:
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/ci-unit-tests-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
# TODO: turn this test and the getblocktemplate test into a matrix, so the jobs use exactly the same diagnostics settings
test-all:
name: Test all
timeout-minutes: 180
runs-on: ubuntu-latest-xl
needs: build
steps:
Expand Down Expand Up @@ -144,6 +145,7 @@
# (The gRPC feature is a zebrad feature, so it isn't needed here.)
test-fake-activation-heights:
name: Test with fake activation heights
timeout-minutes: 60
runs-on: ubuntu-latest
needs: build
steps:
Expand All @@ -167,6 +169,7 @@
# (We activate the gRPC feature to avoid recompiling `zebrad`, but we don't actually run any gRPC tests.)
test-empty-sync:
name: Test checkpoint sync from empty state
timeout-minutes: 60
runs-on: ubuntu-latest
needs: build
steps:
Expand All @@ -189,6 +192,7 @@
# (We activate the gRPC feature to avoid recompiling `zebrad`, but we don't actually run any gRPC tests.)
test-lightwalletd-integration:
name: Test integration with lightwalletd
timeout-minutes: 60
runs-on: ubuntu-latest
needs: build
steps:
Expand All @@ -210,6 +214,7 @@
# Test that Zebra works using the default config with the latest Zebra version.
test-configuration-file:
name: Test CI default Docker config file
timeout-minutes: 60

Check warning on line 217 in .github/workflows/ci-unit-tests-docker.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/ci-unit-tests-docker.yml#L217 

when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-configuration-file" [syntax-check]
Raw output 
.github/workflows/ci-unit-tests-docker.yml:217:5: when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-configuration-file" [syntax-check]
teor2345 marked this conversation as resolved.
Show resolved Hide resolved
needs: build
uses: ./.github/workflows/sub-test-zebra-config.yml
with:
Expand All @@ -222,6 +227,7 @@
# Test reconfiguring the the docker image for tesnet.
test-configuration-file-testnet:
name: Test CI testnet Docker config file
timeout-minutes: 60

Check warning on line 230 in .github/workflows/ci-unit-tests-docker.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/ci-unit-tests-docker.yml#L230 

when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-configuration-file-testnet" [syntax-check]
Raw output 
.github/workflows/ci-unit-tests-docker.yml:230:5: when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-configuration-file-testnet" [syntax-check]
teor2345 marked this conversation as resolved.
Show resolved Hide resolved
needs: build
# Make sure Zebra can sync the genesis block on testnet
uses: ./.github/workflows/sub-test-zebra-config.yml
Expand All @@ -236,6 +242,7 @@
# Test that Zebra works using $ZEBRA_CONF_PATH config
test-zebra-conf-path:
name: Test CI custom Docker config file
timeout-minutes: 60

Check warning on line 245 in .github/workflows/ci-unit-tests-docker.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/ci-unit-tests-docker.yml#L245 

when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-zebra-conf-path" [syntax-check]
Raw output 
.github/workflows/ci-unit-tests-docker.yml:245:5: when a reusable workflow is called with "uses", "timeout-minutes" is not available. only following keys are allowed: "name", "uses", "with", "secrets", "needs", "if", and "permissions" in job "test-zebra-conf-path" [syntax-check]
teor2345 marked this conversation as resolved.
Show resolved Hide resolved
needs: build
uses: ./.github/workflows/sub-test-zebra-config.yml
with:
Expand Down
Loading