ref(ci): consolidate cached states workflows and scripts #8865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
A-infrastructure
gustavovalverde
requested review from
upbqdn
and removed request for
a team
github-actions
bot
added
the
C-trivial
gustavovalverde
force-pushed
the
ref-cache-state
branch
from
436098e
to
dea386c
Compare
We've been using multiple approaches to locate and retrieve cached states in GCP. However, this has made it difficult to reuse the same methods across new workflows or different scenarios.
To address this, we've streamlined the process to make it more reusable in other contexts. This change will support deploying instances from both the `main` branch and `release`, simplifying future implementations and speeding up the process.
Changes:
- Use a single bash script (`gcp-get-cached-disks.sh`) to get cached states names and availability
- Move script logic from `sub-find-cached-disks.yml` to `gcp-get-cached-disks.sh` and adapt `sub-find-cached-disks.yml` to allow to output available disks and disks names.
- Simplify parameters usage in `sub-deploy-integration-tests-gcp.yml` and convert the `Find ${{ inputs.test_id }} cached state disk` step into an independent job, to be able to use the `sub-find-cached-disks.yml` reusable workflow
- Remove repetition in `sub-ci-integration-tests-gcp.yml`
We had a technical debt with some tests using a hardcoded value for the cache directory (`/zebrad-cache`), which generated inconsistency across disks and cached states directories. Changes: - Allow sync tests to use the `ZEBRA_CACHED_STATE_DIR` as the cache directory, if specified - Update the `entrypoint.sh` to reflect this change - Add the `ZEBRA_CACHED_STATE_DIR` variable to the missing tests in `sub-ci-integration-tests-gcp.yml`, and remove extra parameters to call reusable workflows.
gustavovalverde
force-pushed
the
ref-cache-state
branch
from
04d7901
to
b09411b
Compare
gustavovalverde
changed the title
gustavovalverde
changed the title
|
I'm not certain if I should worry about this warning: |
7 tasks
gustavovalverde
requested review from
conradoplg and
oxarbitrage
and removed request for
conradoplg
I saw this in different recent pull requests, i think we should open a new ticket for this one. |
oxarbitrage
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've been using multiple approaches to locate and retrieve cached states in GCP. However, this has made it difficult to reuse the same methods across new workflows or different scenarios.
To address this, we've streamlined the process to make it more reusable in other contexts. This change will support deploying instances from both the
mainbranch andrelease, simplifying future implementations and speeding up the process.Specifications & References
This is the ground work for:
Solution
gcp-get-cached-disks.sh) to get cached states names and availabilitysub-find-cached-disks.ymltogcp-get-cached-disks.shand adaptsub-find-cached-disks.ymlto allow to output available disks and disks names.sub-deploy-integration-tests-gcp.ymland convert theFind ${{ inputs.test_id }} cached state diskstep into an independent job, to be able to use thesub-find-cached-disks.ymlreusable workflowsub-ci-integration-tests-gcp.ymlZEBRA_CACHED_STATE_DIRas the cache directory, if specifiedentrypoint.shto reflect this changeZEBRA_CACHED_STATE_DIRvariable to the missing tests insub-ci-integration-tests-gcp.yml, and remove extra parameters to call reusable workflows.Tests
All test should find their respective cached states and run sucessfully
Follow-up Work
mainnetandtestnetinfra#15PR Author's Checklist
PR Reviewer's Checklist