Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(network): Respond to getheaders requests with a maximum of 160 block headers #8913

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Oct 7, 2024

Motivation

This PR fixes a bug in Zebra's network protocol implementation where Zebra will return fewer than the expected maximum number of block headers in response to getheaders requests which has been falsely indicating to peers that they have reached the tip of Zebra's chain.

This doesn't strictly block the release if we want to also ignore getheaders requests during Zebra's initial sync.

Closes #8907.

Solution

  • Returns a maximum of 160 block headers in response to getheaders requests instead of 158

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added C-bug Category: This is a bug A-network Area: Network protocol updates or fixes P-Medium ⚡ labels Oct 7, 2024
@arya2 arya2 self-assigned this Oct 7, 2024
@arya2 arya2 requested a review from a team as a code owner October 7, 2024 17:20
@arya2 arya2 requested review from upbqdn and removed request for a team October 7, 2024 17:20
mergify bot added a commit that referenced this pull request Oct 7, 2024
@mergify mergify bot merged commit 7313d53 into main Oct 7, 2024
148 checks passed
@mergify mergify bot deleted the 160-block-headers branch October 7, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide what to do about Zebra bug in P2P network header behaviour
2 participants