-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Sustainability Mechanism - ZIP 233 implementation #8930
Open
mariopil
wants to merge
9
commits into
ZcashFoundation:main
Choose a base branch
from
ShieldedLabs:nsm-zip-233
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+941
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
@mariopil Does this PR need to be refreshed when the NSM ZIPs are finalized? |
Yes, the feature flag will be removed here. |
… get_block_template RPC call.
This reverts commit f4fc3a1b20c6192557e61cc7c42ab34e1ae1c78c.
…" flag, added NU7
f164a8a
to
0cac2a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements the ZIP-233, described here.
Specifications & References
ZIP-233
Solution
A new transaction version (
ZFuture
) is introduced, and a new field,burn_amount,
is added to the transaction according to the specification in ZIP-233.This implementation uses the
nsm-zebra
branch of the librustzcash library, which was rebased on the 1410f1449100a417bfbc4f6c7167aa9808e38792 commit.Tests
For testing purposes, a local testnet network was set up. It contained two nodes—a zebra and a zcashd one (with the ZIP-233 implemented, too, PR here). A transaction in a new format containing the
burn_amount
field was created and added to the block by zcashd. The zebra node synced with zcashd without any errors and accepted the block.Follow-up Work
The next PR will contain an implementation of zips ZIP-234 and ZIP-235.
PR Author's Checklist
PR Reviewer's Checklist