Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Sustainability Mechanism - ZIP 233 implementation #8930

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mariopil
Copy link

Motivation

This PR implements the ZIP-233, described here.

Specifications & References

ZIP-233

Solution

A new transaction version (ZFuture) is introduced, and a new field, burn_amount, is added to the transaction according to the specification in ZIP-233.

This implementation uses the nsm-zebra branch of the librustzcash library, which was rebased on the 1410f1449100a417bfbc4f6c7167aa9808e38792 commit.

Tests

For testing purposes, a local testnet network was set up. It contained two nodes—a zebra and a zcashd one (with the ZIP-233 implemented, too, PR here). A transaction in a new format containing the burn_amount field was created and added to the block by zcashd. The zebra node synced with zcashd without any errors and accepted the block.

Follow-up Work

The next PR will contain an implementation of zips ZIP-234 and ZIP-235.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@mariopil mariopil requested review from a team as code owners October 11, 2024 14:48
@mariopil mariopil requested review from upbqdn and removed request for a team October 11, 2024 14:48
@arya2 arya2 added the do-not-merge Tells Mergify not to merge this PR label Oct 26, 2024
This reverts commit f4fc3a1b20c6192557e61cc7c42ab34e1ae1c78c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Tells Mergify not to merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants