Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Update Zebra's MSRV and use the latest Rust Docker image #8956

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(build): Update Zebra's MSRV and use the latest Rust Docker image #8956

merged 1 commit into from
Oct 22, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Oct 21, 2024

Motivation

This test failed on main due to a missing PanicHookInfo struct in the standard library that wasn't added until Rust v1.81.0.

We want to keep Zebra's minimum Rust version up-to-date and use the latest version of Rust in our docker builds.

Solution

Updates RUST_VERSION in Dockerfile and the rust-version field in zebrad/Cargo.toml

PR Author's Checklist

  • The PR name will make sense to users.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added A-rust Area: Updates to Rust code A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-High 🔥 labels Oct 21, 2024
@arya2 arya2 self-assigned this Oct 21, 2024
@arya2 arya2 requested review from a team as code owners October 21, 2024 19:37
@arya2 arya2 requested review from gustavovalverde and upbqdn and removed request for a team October 21, 2024 19:37
mergify bot added a commit that referenced this pull request Oct 21, 2024
@mergify
Merge of #8956
bfdde4e
@mergify mergify bot mentioned this pull request Oct 21, 2024
Closed
@mergify mergify bot merged commit 47b7614 into main Oct 22, 2024
182 checks passed
@mergify mergify bot deleted the update-msrv branch October 22, 2024 00:41
upbqdn
upbqdn reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we go with 1.81 and 1.82, and not only 1.82?

@arya2
Copy link
Contributor Author

arya2 commented Oct 22, 2024

Why did we go with 1.81 and 1.82, and not only 1.82?

v1.81 is the new minimum rust version because it added the PanicHookInfo struct Zebra is using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn left review comments

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@gustavovalverde gustavovalverde Awaiting requested review from gustavovalverde gustavovalverde is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@arya2 arya2

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-High 🔥
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arya2 @upbqdn @oxarbitrage