-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): Fixes a bug in the sending_transactions_using_lightwalletd
test
#9052
base: main
Are you sure you want to change the base?
Conversation
4234291
to
0ecf779
Compare
… code for sending transactions to its own fn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test could also fail due to transactions having unpaid actions (which are allowed by default in blocks but rejected by default in the mempool).
I'm looking into why it failed here: https://github.com/ZcashFoundation/zebra/actions/runs/11979091682/job/33400891720?pr=9052#step:15:844 where that transaction did pay the conventional fee.
The log also indicates that lightwalletd can't parse errors returned from Zebra's sendrawtransaction
method, seemingly because it's expecting a colon-separated string but is receiving JSON.
…eturn an error for more detailed error info
Motivation
This PR fixes a bug in the
sending_transactions_using_lightwalletd
test where transactions from multiple future blocks are being sent to the mempool without committing prior blocks to the chain.Solution
Submits blocks to the state after sending their transactions to the mempool.
Tests
The test should pass in CI.
PR Author's Checklist
PR Reviewer's Checklist