Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Fixes a bug in the sending_transactions_using_lightwalletd test #9052

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Nov 22, 2024

Motivation

This PR fixes a bug in the sending_transactions_using_lightwalletd test where transactions from multiple future blocks are being sent to the mempool without committing prior blocks to the chain.

Solution

Submits blocks to the state after sending their transactions to the mempool.

Tests

The test should pass in CI.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 self-assigned this Nov 22, 2024
@github-actions github-actions bot added C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Nov 22, 2024
@arya2 arya2 marked this pull request as ready for review November 22, 2024 19:33
@arya2 arya2 requested a review from a team as a code owner November 22, 2024 19:33
@arya2 arya2 requested review from upbqdn and removed request for a team November 22, 2024 19:33
Copy link
Contributor Author

@arya2 arya2 Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test could also fail due to transactions having unpaid actions (which are allowed by default in blocks but rejected by default in the mempool).

I'm looking into why it failed here: https://github.com/ZcashFoundation/zebra/actions/runs/11979091682/job/33400891720?pr=9052#step:15:844 where that transaction did pay the conventional fee.

The log also indicates that lightwalletd can't parse errors returned from Zebra's sendrawtransaction method, seemingly because it's expecting a colon-separated string but is receiving JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant