Sell order function #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The function `handleCollateralTokensAfterSell` was still expecting to transfer collateral, which would revert in the current implementation. - The _sellOrder` function had a conditional check which would let the contract revert given there will not be any collateral in the contract
vendrell46
reviewed
Dec 9, 2024
| @@ -54,28 +54,30 @@ interface IERC20Issuance_Blacklist_v1 is IERC20Issuance_v1 { | |||
| error ERC20Issuance_Blacklist_BlacklistedAddress(address account); | |||
|
|
|||
| /// @notice Thrown when batch operation exceeds the maximum allowed size | |||
| error ERC20Issuance_Blacklist_BatchLimitExceeded(uint256 provided, uint256 limit); | |||
| error ERC20Issuance_Blacklist_BatchLimitExceeded(uint provided, uint limit); | |||
There was a problem hiding this comment.
What's the reason for using uint instead of uint256?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done?
_sellOrder_handleCollateralTokensAfterSellas the payout is handled through the queue