Refactor testing usp fm #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed unused imports - moved files to right directory - renamed files - cleaned up setup by removing unnecessary initialization, instead reuse existing setup from ModuleTest - format code (make fmt)
- Moved file - Removed unnecessary imports - Use only exposed mock for testing
- Remove imports - Refactor most of the setup - Add exposed mock - Removed OraclePriceMock and InvalidMock - Added simpler oracle mockf - fmt
Refactor: Initial refactor of testing
…_succeedsGivenMaxAmount and comment testExternalQueue_succeedsGivenSingleRedemptionOrder
What has been done: - Add msg.sender to events - Move logic of modifier to internal function (Inverter Standard)
- Cleaned setup - Moved imports and functions to correct place (Inverter Standard) - Added extensive gherkin - Add some missing tests
|
Double check if this file is needed? |
Zitzak
commented
Jan 16, 2025
| @@ -126,17 +126,9 @@ contract LM_ManualExternalPriceSetter_v1 is | |||
| uint issuancePrice_, | |||
| uint redemptionPrice_ | |||
| ) external onlyModuleRole(PRICE_SETTER_ROLE) { | |||
| if (issuancePrice_ == 0 || redemptionPrice_ == 0) { | |||
There was a problem hiding this comment.
Cleaned up this function from what was incoming/merged from the feature branch. Fyi
Zitzak
merged commit bcc22b2
into
ZealynxSecurity/Feature/FM_PC_ExternalPrice
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.