feat: use XBlockI18NService js translations #2
Conversation
ahmadabuwardeh
force-pushed
the
feature/delete_transfix
branch
2 times, most recently
from
78ed4ab
to
a626381
Compare
|
@ahmadabuwardeh would you mind fixing the conflicts and changelog? Thanks!! |
ahmadabuwardeh
force-pushed
the
feature/delete_transfix
branch
2 times, most recently
from
16bf96a
to
202cff1
Compare
|
@ahmadabuwardeh please revert the We only need to rebase over If we'd like to refactor the code it should be in a separate commit, and ideally separate pull request. |
ahmadabuwardeh
force-pushed
the
feature/delete_transfix
branch
2 times, most recently
from
2c8da86
to
b9afb1e
Compare
ahmadabuwardeh
force-pushed
the
feature/delete_transfix
branch
from
b9afb1e
to
7ef92fc
Compare
OmarIthawi
changed the title
| return self.runtime.local_resource_url(self, deprecated_url) | ||
|
|
||
| return None | ||
|
|
||
| def validate_field_data(self, validation, data): |
There was a problem hiding this comment.
@ahmadabuwardeh thanks again!
Please revert all refactoring changes to this pull request. We only need the _get_statici18n_js_url and _get_deprecated_i18n_js_url.
| @@ -31,6 +31,14 @@ def _(text): | |||
| return text | |||
|
|
|||
|
|
|||
| def ngettext_fallback(text_singular, text_plural, number): | |||
There was a problem hiding this comment.
@ahmadabuwardeh Looking at this change it makes sense to have in a separate pull request.
DummyTranslationService is roughly similar to xblock.xblock.runtime.NullI18nService which can be used.
However, I'd like to understand the motivation behind it and if it's crucial for this pull request.
Related: