Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce embed mode #618

Merged
merged 3 commits into from
Dec 2, 2023
Merged

feat: introduce embed mode #618

merged 3 commits into from
Dec 2, 2023

Conversation

dyon21
Copy link
Contributor

@dyon21 dyon21 commented Nov 18, 2023

To use app.zenuml.com as an embedded editor on zenuml.com, it needs to be made able to get the code from the URL.

This presents a temporary solution, we can use a diagram-id to render a certain diagram in future.

Besides, I noticed that the default layoutMode is currently set to mode2. I fix it to mode1.

@dyon21 dyon21 requested a review from MrCoder November 18, 2023 08:10
@dyon21 dyon21 marked this pull request as draft November 19, 2023 12:24
@dyon21 dyon21 force-pushed the feat/embedable branch 2 times, most recently from 2ee69fb to 1513e1a Compare November 25, 2023 09:00
@dyon21 dyon21 changed the title feat: render code from URL feat: introduce embed mode Nov 25, 2023
@dyon21 dyon21 marked this pull request as ready for review November 25, 2023 09:19
src/components/app.jsx Outdated Show resolved Hide resolved
@dyon21 dyon21 marked this pull request as draft November 27, 2023 10:06
@dyon21 dyon21 marked this pull request as ready for review December 1, 2023 12:45
@MrCoder MrCoder merged commit 1afdb65 into master Dec 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants