Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diesel tractor #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add diesel tractor #102

wants to merge 2 commits into from

Conversation

Erikvv
Copy link
Member

@Erikvv Erikvv commented Jan 30, 2025

No description provided.

@Luc-Sol @Erikvv
Added a new J_EADieselTractor
48b04ed 
also added a collection to the GC canvas for these assets and updateAllFlows at operateFixedAssets
@Erikvv Erikvv requested a review from GillisHommen January 30, 2025 13:18
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

@Erikvv Erikvv requested a review from Luc-Sol January 30, 2025 13:23
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

@Erikvv
Copy link
Member Author

Erikvv commented Jan 30, 2025 •
edited
Loading

  • Fix: putting kW in flows map instead of kWh
  • Did the conversion from L to kWh earlier (i guess it can be done even earlier in the constructor)

@GillisHommen
Copy link
Contributor

Is a separate collection on the GC-canvas needed? What makes this asset different from a 'consumptionAsset', from the GCs frame of reference?

@Erikvv
Copy link
Member Author

Erikvv commented Feb 3, 2025

Is a separate collection on the GC-canvas needed? What makes this asset different from a 'consumptionAsset', from the GCs frame of reference?

After consulting @Luc-Sol, changed it to add the tractor to profileAsset collection instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

@Erikvv
Refactor diesel tractor
99af8b4 
I am aware that this is nitpicking and doesn't solve any fundamental
issue.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-island-0b93ff303-102.westeurope.5.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GillisHommen GillisHommen Awaiting requested review from GillisHommen

@Luc-Sol Luc-Sol Awaiting requested review from Luc-Sol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erikvv @GillisHommen @Luc-Sol