Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flakes and fix build error with Go on newer nixpkgs version. #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update flakes and fix build error with Go on newer nixpkgs version. #23

wants to merge 2 commits into from

Conversation

ReneHollander
Copy link

buildGoModule recently changed and the hash attributes are now called differently:

error: buildGoModule: Expect vendorHash instead of vendorSha256

@ReneHollander ReneHollander force-pushed the master branch 3 times, most recently from b3dd132 to 2f85c2f Compare December 22, 2024 15:32
@ReneHollander
Rework the driver:
a44d837 
- the driver now takes care of mounting and unmounting datasets
- datasets now use mountpoint=legacy which means we don't need to rely on zfs-mount.service to mount the datasets initially
- remove some features i don't use to make my life easier
- update dependencies and fix tests

Why? relying on zfs-mount.service means it's harder to correctly order shutdown. This should no longer matter since as long as the docker-zfs-plugin service is correctly ordered in relation to the zfs pool that houses the data shutdown should be cleaner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ReneHollander