-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added change_roles automod action #284
Open
metal0
wants to merge
19
commits into
ZeppelinBot:master
Choose a base branch
from
metal0:automod-action-change-roles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almeidx
requested changes
Sep 8, 2021
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
Co-authored-by: Almeida <[email protected]>
WARNING!!!!This will cause misconfiguration errors on bot startup (due to the config checks I added) if anyone has both Flokie tried to add this to his instance and was instantly met with the misconfiguration error, do NOT merge this without some sort of migration WARNING!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR is meant to fix the issue of having both
add_roles
andremove_roles
not functioning when used together.I tried to fix the core issue at hand with the individual methods (i.e. the Member object's roles not being up-to-date by the time it reaches the 2nd action) but there was no super easy fix for this that I could find.
Regardless it would've still been 2 dapi requests, with this PR all role changes originating from a rule are now guaranteed to only be a single dapi request (since you can no longer use both
add_roles
andremove_roles
)@almeidx wtb review