fix: correct embed schemas #422
Conversation
Correct embed schemas according to the Discord documentation. Notable change: fixes ability to set `icon_url` to `author` in embeds.
|
Thank you for contributing to Zeppelin! We require contributors to sign our Contributor License Agreement (CLA). To let us review and merge your code, please visit https://github.com/ZeppelinBot/CLA to sign the CLA! |
|
CLA pending here — ZeppelinBot/CLA#35 |
| @@ -298,8 +299,8 @@ export const tEmbed = t.type({ | |||
| t.type({ | |||
| name: t.string, | |||
| url: tNullable(t.string), | |||
| width: tNullable(t.number), | |||
| height: tNullable(t.number), | |||
There was a problem hiding this comment.
Despite the fact that we should not allow setting these, as they are ignored by Discord's API, we cannot remove them from the schema as that would break existing configurations that are defining these properties. This also applies to the schema below
For clarity, I'm only talking about the removal of width and height.
There was a problem hiding this comment.
Additionally, setting proxy URLs should also not be supported as that will also be ignored by Discord.
Correct embed schemas according to the Discord documentation.
Notable change: fixes ability to set
icon_urltoauthorin embeds.