chore(file-download): enable downloading folder/file contents from file directory #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will want to test this in dev as well |
priyakanabar-crest
force-pushed
the
enable-file-download-from-file-system
branch
3 times, most recently
from
3bfafa1
to
362e85b
Compare
|
@Carson-Shaar I have updated the code and rebase the branch |
| @@ -79,6 +87,12 @@ | |||
| </template> | |||
| </v-snackbar> | |||
|
|
|||
| <FileFolderDownloadDialog | |||
There was a problem hiding this comment.
All of the dialogs should live under the list item like this:
<v-list-item
v-if="<some_bool>"
link
prepend-icon="mdi-account-outline"
title="Manage Access"
>
<ShareProjectDialog :project-name="item.name" />
</v-list-item>
Note the link directive. Please refactor these as needed and use props in the dialogs
|
Please rebase this to resolve conflicts and test with very large folders |
priyakanabar-crest
force-pushed
the
enable-file-download-from-file-system
branch
2 times, most recently
from
362e85b
to
571eb58
Compare
|
Rebased solve conflicts and updated downlader dialog to be in v-list-item |
Carson-Shaar
force-pushed
the
enable-file-download-from-file-system
branch
from
394bcb1
to
87cbbdc
Compare
… add helper functions code and use it from there and removed unwnated code from the components
…tem ,updated dilaog for download and updated api path formation
Carson-Shaar
force-pushed
the
enable-file-download-from-file-system
branch
from
87cbbdc
to
7107d61
Compare
Carson-Shaar
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to download the contents of a folder/file directly from the file directory.