Added click and drag #92
Conversation
fix images - development
# Conflicts: # utils/getImage.js
On the grid view, not list view. That works nicely |
I've also noticed it, but I'm not sure how to fix it. It seems to be a problem with mousedown event not firing or propagating properly. |
|
That should have fixed it |
|
d939f41 havent fixed it, now it does not select the first item you have clicked. |
Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](axios/axios@v0.19.2...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]>
add missing Smissmas 2020 effects
…0.21.1 Bump axios from 0.19.2 to 0.21.1
| 'Apotheosis', | ||
| 'Ascension', | ||
| 'Reindoonicorn Rancher', | ||
| // 'Reindoonicorn Rancher', |
| '5061;6': 'a89a8c', // Waterlogged Lab Coat | ||
| '5036;6': '7c6c57', // Ye Olde Rustic Colour | ||
| '5028;6': '424f3b' // Zepheniah's Greed | ||
| // A Color Similar to Slate |
There was a problem hiding this comment.
Why did you decide to open new lines? In practice this saves about 2 characters of horizontal space
| background-color: #666; | ||
| } | ||
| .item:hover .price { | ||
| visibility: visible; | ||
| } | ||
|
|
||
| #pricelist { |
There was a problem hiding this comment.
what is the problem with targeting ID ?
There was a problem hiding this comment.
https://stackoverflow.com/questions/8084555/why-selecting-by-id-is-not-recommended-in-css You're basically cornering yourself in, and won't be able to override it later with another selector.
| @@ -61,6 +61,16 @@ const app = new Vue({ | |||
| list: false | |||
| }, | |||
| methods: { | |||
| mouseEntered: function (item, e) { | |||
| if (this.multiSelect.enabled && (e.buttons && e.buttons==1) && e.button == 0) { | |||
There was a problem hiding this comment.
e.buttons == 1 instead of e.buttons==1 , seems not to match your codestyle
- try not to hook everything in brackets, a general preferance in JS is
if (!this.multiSelect.enabled || !(e.buttons && e.buttons==1) || e.button !== 0)
return;
And that way save on horizontal space
| @@ -259,7 +259,9 @@ | |||
| </div> | |||
|
|
|||
| <div v-if="!list" class="d-flex mt-3 flex justify-content-center flex-wrap" id="pricelist"> | |||
| <div class="item item-grid m-1" v-for="item in pricelistSorted" :key="item.sku" :style="{ backgroundImage: `url( ${item.style.image_small} ), url( ${item.style.effect} )`, backgroundColor: item.style.quality_color, borderStyle: item.style.craftable? false : 'dashed', opacity: item.enabled?1:0.5, borderColor: item.style.border_color}" @click="itemClick(item, $event)"> | |||
| <div class="item item-grid m-1" v-for="item in pricelistSorted" :key="item.sku" | |||
| :style="{ backgroundImage: `url( ${item.style.image_small} ), url( ${item.style.effect} )`, backgroundColor: item.style.quality_color, borderStyle: item.style.craftable? false : 'dashed', opacity: item.enabled?1:0.5, borderColor: item.style.border_color}" | |||
There was a problem hiding this comment.
Please split the style-properties up on new lines
| <div class="item item-grid m-1" v-for="item in pricelistSorted" :key="item.sku" :style="{ backgroundImage: `url( ${item.style.image_small} ), url( ${item.style.effect} )`, backgroundColor: item.style.quality_color, borderStyle: item.style.craftable? false : 'dashed', opacity: item.enabled?1:0.5, borderColor: item.style.border_color}" @click="itemClick(item, $event)"> | ||
| <div class="item item-grid m-1" v-for="item in pricelistSorted" :key="item.sku" | ||
| :style="{ backgroundImage: `url( ${item.style.image_small} ), url( ${item.style.effect} )`, backgroundColor: item.style.quality_color, borderStyle: item.style.craftable? false : 'dashed', opacity: item.enabled?1:0.5, borderColor: item.style.border_color}" | ||
| @click="itemClick(item, $event)" @mouseenter="mouseEntered(item, $event)"> |
There was a problem hiding this comment.
either make the decision, in general HTML, to put attributes on all new lines, or put them all on the same line. this will avoid confusion.
Added the option to click and drag while selecting multiple items.
#91