Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call getSettingsAndNavigate less often #2660

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

myxmaster
Copy link
Contributor

@myxmaster myxmaster commented Dec 21, 2024

Description

Before, getSettingsAndNavigate() was called everytime Wallet.tsx gained focus. Since processing getSettingsAndNavigate() takes some time, this resulted in the app not being responsive for a short time. Example: When you closed the menu and then immediately clicked on a balance slider, it was not responding.

With this PR the flow is optimized, so getSettingsAndNavigate() is only called:

  • via handleFocus():
    • On initial load (using existing initialLoad state)
    • When coming from Lockscreen (using new comingFromLockscreen flag triggerSettingsRefresh navigation param)
    • When POS was enabled (using new posWasEnabled flag)
  • via handleAppStateChange():
    • when app comes from background (no PIN/password configured)

Additionally fixed a bug, where autonavigation into POS didn't work in this edge case:

  • Configure a PIN/password, enable Require login after app returns from background
  • Enable POS and leave menu (autonavigate works)
  • Disable POS and leave menu
  • Put the app in background and reopen it, log in
  • Enable POS and leave menu
    => no autonavigate is happening

Root cause was in Lockscreen.tsx, now it is only setting posStatus to 'inactive' when POS is actually enabled.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

views/Lockscreen.tsx Outdated Show resolved Hide resolved
@@ -144,7 +159,7 @@ export default class Lockscreen extends React.Component<
!deleteDuressPin
) {
SettingsStore.setLoginStatus(true);
this.proceed('Wallet');
this.proceed('Wallet', true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the true do here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it sets triggerSettingsRefresh to true in proceed() which results in Wallet.tsx:handleFocus() calling getSettingsAndNavigate() which leads to (also) calling fetchData(), and that usually makes sense when we display Wallet view to make sure we are displaying up-to-date data.

But... I am wondering, when are those conditions met at all?

if (
            posEnabled !== PosEnabled.Disabled &&
            SettingsStore.posStatus === 'active' &&
            !attemptAdminLogin &&
            !deletePin &&
            !deleteDuressPin
        )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants