Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity: LND: limit to 500 invoices + payments #2751

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jan 18, 2025

Description

To help with Activity performance we are modifying the LND activity calls to include hard limits of 500:

500 invoices
500 LN payments

Limit of 500 txs is now in a separate PR here: #2771 as max_transactions on GetTransactions still hasn't been cut into an LND release yet

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added the Activity Activity view label Jan 18, 2025
@kaloudis kaloudis changed the title Activity: limit to 500 items of each taxonomy Activity: LND: limit to 500 invoices + payments Jan 24, 2025
@kaloudis kaloudis mentioned this pull request Jan 24, 2025
30 tasks
@kaloudis kaloudis added the LND Issues specific to LND nodes label Jan 24, 2025
@kaloudis kaloudis marked this pull request as ready for review January 24, 2025 17:34
@kaloudis kaloudis added this to the v0.9.5 milestone Jan 24, 2025
@kaloudis kaloudis requested a review from shubhamkmr04 January 24, 2025 17:44
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit be83aaa into ZeusLN:master Jan 27, 2025
4 checks passed
@kaloudis kaloudis deleted the activity-500 branch January 27, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Activity Activity view LND Issues specific to LND nodes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants