Add the evict reason as a metric tag so we can categorize the evict reason. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fusioncache.memory.evict" used for the counter CounterMemoryEvict
|
Hi Joe, nice idea! In this case though, the possible values are very limited so it LGTM, I just changed slightly the string identifier to be more aligned with an existing one. What do you think? |
|
That looks great! |
|
Hi all, I just released v1.0.0-preview1 🥳 Please try it out so we can spot any potential issue before the official |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned adding the reason tag in the OpenTelemetry support discussion. It may have gotten lost in the naming discussion that took over my comment.
Seems like a reasonable addition. What do you think? I used it in my plugin and in many working code deployments.
Thank you.