Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continuous integration workflow #248

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented May 28, 2024

Using dotnet test works just fine on any platform and is much easier to maintain than custom solutions such as Bullseye / Cake / NUKE in my opinion.

@0xced
Copy link
Contributor Author

0xced commented May 28, 2024

Well, now we have actual test failures. 🙁 But that's still progress over tests not running! 😁

I hope you don't mind me flooding you will pull requests, this is my (admittedly weird) way of showing my appreciation to open source projects I appreciate.

@jodydonetti
Copy link
Collaborator

Hey @0xced ahahah no worries, I'm really glad about your contributions, appreciate it!
I'll take a look at them in the weekend and will update you.
Thanks!

Copy link
Collaborator

@jodydonetti jodydonetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jodydonetti jodydonetti self-assigned this May 31, 2024
@jodydonetti jodydonetti added the enhancement New feature or request label May 31, 2024
@jodydonetti jodydonetti added this to the v1.2.0 milestone May 31, 2024
@jodydonetti jodydonetti merged commit 53fea69 into ZiggyCreatures:main May 31, 2024
1 check failed
@0xced 0xced deleted the fix-ci branch May 31, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants